Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Improve the accessibility of the highlight editor (bug 1881743) #17788

Merged
merged 1 commit into from
Mar 11, 2024

Conversation

calixteman
Copy link
Contributor

No description provided.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this perhaps be tested, since a11y-stuff feels easy to accidentally regress otherwise?

@calixteman
Copy link
Contributor Author

What kind of test could you imagine here ?
Checking for the presence of an a11y attribute, for example.

@Snuffleupagus
Copy link
Collaborator

What kind of test could you imagine here ?

No idea, just asking if it's possible to (easily) test this; if not then I suppose that it's fine as-is.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4b49fb4c18a5564/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cbe0886ceb9a92a/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/cbe0886ceb9a92a/output.txt

Total script time: 6.45 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/4b49fb4c18a5564/output.txt

Total script time: 16.97 mins

  • Integration Tests: Passed

@calixteman calixteman merged commit e647311 into mozilla:master Mar 11, 2024
9 checks passed
@calixteman calixteman deleted the bug1881743 branch March 11, 2024 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants