-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Annotations] Widget annotations must be in front of the other ones (bug 1883609) #17776
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please maintain consistency with the existing Popup-related code. (Especially since most documents don't even have Widget-annotations, and Link-annotations being the by far most common type.)
Also, running the entire test-suite is probably a good idea given the changes made here.
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3ccac23945a1133/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/0a011fa22939a61/output.txt |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/844469cd7e52087/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/1170866bb235048/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/844469cd7e52087/output.txt Total script time: 25.27 mins
Image differences available at: http://54.241.84.105:8877/844469cd7e52087/reftest-analyzer.html#web=eq.log |
And this patch is fixing an issue in issue13003.pdf. |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/1170866bb235048/output.txt Total script time: 39.43 mins
Image differences available at: http://54.193.163.58:8877/1170866bb235048/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/d8450cf9f1f7af0/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/036578242403fd6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/d8450cf9f1f7af0/output.txt Total script time: 18.78 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/036578242403fd6/output.txt Total script time: 26.71 mins
|
No description provided.