-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unneeded tweakWebpackOutput
usage in the gulpfile (PR 17637 follow-up)
#17678
Conversation
…follow-up) After the changes in PR 17637 there's no longer any reason to invoke `tweakWebpackOutput` without an argument, since the `__non_webpack_import__` re-writing was moved into the Babel plugin. This way we can avoid a (little) bit of unnecessary parsing during building.
555c2f8
to
751611f
Compare
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a84860929e85dc1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a84860929e85dc1/output.txt Total script time: 1.22 mins Published |
/botio xfatest |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/37c1cbfdde5d14c/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/077ff68c099bfa5/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/077ff68c099bfa5/output.txt Total script time: 10.94 mins
Image differences available at: http://54.241.84.105:8877/077ff68c099bfa5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/37c1cbfdde5d14c/output.txt Total script time: 20.82 mins
Image differences available at: http://54.193.163.58:8877/37c1cbfdde5d14c/reftest-analyzer.html#web=eq.log |
Thanks! |
After the changes in PR #17637 there's no longer any reason to invoke
tweakWebpackOutput
without an argument, since the__non_webpack_import__
re-writing was moved into the Babel plugin.This way we can avoid a (little) bit of unnecessary parsing during building.