Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Skip any whitespace after the first object in linearized PDFs (issue 17665) #17666

Merged
merged 1 commit into from
Feb 13, 2024
Merged

Skip any whitespace after the first object in linearized PDFs (issue 17665) #17666

merged 1 commit into from
Feb 13, 2024

Conversation

Snuffleupagus
Copy link
Collaborator

Please note: I don't think that we have any good way of testing this, however the code is now consistent with the non-linearized branch in the PDFDocument.startXRef getter.

@Snuffleupagus Snuffleupagus linked an issue Feb 12, 2024 that may be closed by this pull request
Skip white spaces after the first endobj in order to get a correct startxref value #17665
Closed
@calixteman
Copy link
Contributor

Can't we write a test to load empty.pdf and check that startXref has the correct value ? or something like that ?

@Snuffleupagus
Skip any whitespace after the first object in linearized PDFs (issue …
37e98e3 
…17665)

This way the code is now consistent with the non-linearized branch in the `PDFDocument.startXRef` getter.
calixteman
calixteman approved these changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bd60e99ac29d77f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c5e954a108526ff/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/c5e954a108526ff/output.txt

Total script time: 24.68 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 23
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/c5e954a108526ff/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/bd60e99ac29d77f/output.txt

Total script time: 41.70 mins

  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 4

Image differences available at: http://54.193.163.58:8877/bd60e99ac29d77f/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus merged commit e60329c into mozilla:master Feb 13, 2024
9 checks passed
@Snuffleupagus Snuffleupagus deleted the issue-17665 branch February 13, 2024 11:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Skip white spaces after the first endobj in order to get a correct startxref value
3 participants
@Snuffleupagus @calixteman @moz-tools-bot