Implement caret browsing mode (bug 807730) #17611
Conversation
There was a problem hiding this comment.
Sorry, but I'd really like to see a solution to issue #17561 before we add even more functionality on top of this; please see the example added in #17561 (comment).
As said in the mentioned bug, I've a solution for it, but this feature has a higher priority. |
calixteman
force-pushed
the
caret_browsing_mode
branch
from
43710fb to
4dddb9d
Compare
There was a problem hiding this comment.
Leaving a couple of comments/questions, but I've not yet had time to really look at the CaretBrowsingMode-implementation in any detail.
Also, does this work correctly in RTL mode? Can be tested e.g. with http://localhost:8888/web/viewer.html#locale=he
calixteman
force-pushed
the
caret_browsing_mode
branch
from
4dddb9d to
af3462a
Compare
calixteman
force-pushed
the
caret_browsing_mode
branch
from
af3462a to
064ec3a
Compare
Yep I ran with locale=he and a pdf in hebrew and I think everything is working correctly (my skills in hebrew are close to null it's why "I think..."). |
There was a problem hiding this comment.
r=me, assuming that:
you've successfully tested this in RTL mode, e.g. with http://localhost:8888/web/viewer.html#locale=he- all test-suites pass.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4a53ac83fe6bfa8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/caad736aef74fcd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/4a53ac83fe6bfa8/output.txt Total script time: 25.09 mins
Image differences available at: http://54.241.84.105:8877/4a53ac83fe6bfa8/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/caad736aef74fcd/output.txt Total script time: 41.85 mins
Image differences available at: http://54.193.163.58:8877/caad736aef74fcd/reftest-analyzer.html#web=eq.log |
|
/botio-windows integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/979a71d61328874/output.txt |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/979a71d61328874/output.txt Total script time: 16.12 mins
|
The users will be able to navigate within the pdf in using the arrows and they'll be able to select some text, for example in order to highlight it.
calixteman
force-pushed
the
caret_browsing_mode
branch
from
064ec3a to
81466ee
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7ba383a9ddadee7/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5b63aa4bed38c86/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7ba383a9ddadee7/output.txt Total script time: 6.09 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/5b63aa4bed38c86/output.txt Total script time: 17.68 mins
|
|
The test failure on the windows bot was due to the EOL (\r\n instead of \n), it's fixed now. |
The users will be able to navigate within the pdf in using the arrows and they'll be able to select some text, for example in order to highlight it.