Re-factor DefaultExternalServices into a regular class, without static methods
#17588
Conversation
Given the simplicity of the `createDownloadManager` method, we can leverage import maps to directly initialize the correct `DownloadManager`-instance depending on the build.
Given the simplicity of the `createPreferences` method, we can leverage import maps to directly initialize the correct `Preferences`-instance depending on the build.
…tic methods The `DefaultExternalServices` code, which is used to provide build-specific functionality, is very old. This results in a pattern where we first initialize `PDFViewerApplication.externalServices` and then *override* it for the different builds. By converting `DefaultExternalServices` into a "regular" class, and leveraging import maps, we can directly initialize the correct instance depending on the build.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f2ccb44b446f4ba/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/f2ccb44b446f4ba/output.txt Total script time: 1.22 mins Published |
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a7b4eacf5d0fee1/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/24447e09a499960/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/a7b4eacf5d0fee1/output.txt Total script time: 24.65 mins
Image differences available at: http://54.241.84.105:8877/a7b4eacf5d0fee1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/24447e09a499960/output.txt Total script time: 39.53 mins
Image differences available at: http://54.193.163.58:8877/24447e09a499960/reftest-analyzer.html#web=eq.log |
Snuffleupagus
force-pushed
the
DefaultExternalServices-lighten
branch
from
4bb05e0 to
5dd25b6
Compare
|
Thank you for improving this! |
Please refer to the individual commit messages for additional details.