[Editor] Slightly simplify the serialization of an highlight annotation #17517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
approved these changes
Jan 15, 2024
We were computing width and height of the annotation before serializing which is useless because the rect already contains this information.
calixteman
force-pushed
the
editor_highlight_simplify_ser
branch
from
8f094e1 to
ee72b32
Compare
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5c686b80467c6eb/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/88a8258e0442cad/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5c686b80467c6eb/output.txt Total script time: 5.99 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/88a8258e0442cad/output.txt Total script time: 22.26 mins
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were computing width and height of the annotation before serializing which is useless because the rect already contains this information.