-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw a JpegError
when a JPEG image has no frame data (issue 17302)
#17303
Conversation
Given that there's nothing to parse in this case, since we're dealing with an invalid JPEG image, throwing an *explicit* Error makes sense here.
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f2838404eff167f/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a35fade86eb53ca/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f2838404eff167f/output.txt Total script time: 24.77 mins
Image differences available at: http://54.241.84.105:8877/f2838404eff167f/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a35fade86eb53ca/output.txt Total script time: 34.43 mins
Image differences available at: http://54.193.163.58:8877/a35fade86eb53ca/reftest-analyzer.html#web=eq.log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure that it's so useful to throw here instead of throwing at the next line...
That said it doesn't really hurt.
LGTM. Thank you.
Agreed; the only reason that I think this makes sense to do here is because we're publishing the PDF.js image decoders separately in |
Given that there's nothing to parse in this case, since we're dealing with an invalid JPEG image, throwing an explicit Error makes sense here.