Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the editor-buttons in the main toolbar #17294

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Move the editor-buttons in the main toolbar #17294

merged 1 commit into from
Nov 22, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

By introducing a CSS variable for the editor-toolbars we're able to handle resizing of the viewer without complicating the code too much.

@Snuffleupagus
Copy link
Collaborator Author

@calixteman Do we want to change this now, or is the design-spec not finalized yet?

@Snuffleupagus
Move the editor-buttons in the main toolbar
5df7c97 
By introducing a CSS variable for the editor-toolbars we're able to handle resizing of the viewer without complicating the code too much.
@calixteman
Copy link
Contributor

Yep we can change this now.
I'm fine to take this PR as it is, but we should really think about removing these magic numbers and use some layout stuff (flex or whatever).

@Snuffleupagus Snuffleupagus force-pushed the toolbarViewerRight-reorder branch from e6634d1 to 5df7c97 Compare November 22, 2023 12:37
@Snuffleupagus Snuffleupagus marked this pull request as ready for review November 22, 2023 12:38
@Snuffleupagus
Copy link
Collaborator Author

but we should really think about removing these magic numbers and use some layout stuff (flex or whatever).

Sure; the entire viewer-CSS is quite old in many parts and could definitely benefit from modernization (it's just that all such changes need careful manual testing, which tends to be slow.)

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bdf48ed8fef0fd5/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bdf48ed8fef0fd5/output.txt

Total script time: 1.43 mins

Published

calixteman
calixteman approved these changes Nov 22, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 5781e72 into mozilla:master Nov 22, 2023
7 checks passed
@Snuffleupagus Snuffleupagus deleted the toolbarViewerRight-reorder branch November 22, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
viewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @calixteman @moz-tools-bot