Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependencies and translations to the most recent versions #17260

Merged
merged 2 commits into from
Nov 11, 2023

Conversation

timvandermeij
Copy link
Contributor

No description provided.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/573e3d31289290c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/573e3d31289290c/output.txt

Total script time: 1.41 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/72f64c0d49ea5ef/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/cffdc1069b21103/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/72f64c0d49ea5ef/output.txt

Total script time: 25.03 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 18
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/72f64c0d49ea5ef/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/cffdc1069b21103/output.txt

Total script time: 36.32 mins

  • Font tests: FAILED
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 19

Image differences available at: http://54.193.163.58:8877/cffdc1069b21103/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator

It seems that the integrationtest failed at the same exact point on both Linux and Windows, hopefully that's just really bad luck and not something broken by the Puppeteer update.

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1eeb55b4594fc87/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9480a813b92e60b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/1eeb55b4594fc87/output.txt

Total script time: 5.74 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/9480a813b92e60b/output.txt

Total script time: 18.15 mins

  • Integration Tests: FAILED

@timvandermeij
Copy link
Contributor Author

Yikes, that same test times out fails locally as well. I'll have a look at what's wrong with it; it could be a pre-existing issue in the test that only surfaces now for some reason. I didn't find anything particularly interesting between Puppeteer 21.5.0 and 21.5.1, but apparently something changed to make it show up.

@timvandermeij
Copy link
Contributor Author

I looked into this and could already reproduce this locally with master. I have made #17261 to check this further and it's indeed already failing on master, so it's not related to this PR. I'll check if I can find where this started failing because it must have been a very recent change given that the integration tests passed two days ago.

@timvandermeij
Copy link
Contributor Author

I have bisected it and created #17262 to track the integration test problem which indeed turned out to be pre-existing issue.

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, this should be fine to land as-is since the integrationtest failure is unrelated; thank you!

@timvandermeij timvandermeij merged commit 26fcd26 into mozilla:master Nov 11, 2023
5 checks passed
@timvandermeij timvandermeij deleted the updates branch November 11, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants