-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update dependencies and translations to the most recent versions #17260
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/573e3d31289290c/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/573e3d31289290c/output.txt Total script time: 1.41 mins Published |
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/72f64c0d49ea5ef/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cffdc1069b21103/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/72f64c0d49ea5ef/output.txt Total script time: 25.03 mins
Image differences available at: http://54.241.84.105:8877/72f64c0d49ea5ef/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cffdc1069b21103/output.txt Total script time: 36.32 mins
Image differences available at: http://54.193.163.58:8877/cffdc1069b21103/reftest-analyzer.html#web=eq.log |
It seems that the /botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1eeb55b4594fc87/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/9480a813b92e60b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1eeb55b4594fc87/output.txt Total script time: 5.74 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/9480a813b92e60b/output.txt Total script time: 18.15 mins
|
Yikes, that same test times out fails locally as well. I'll have a look at what's wrong with it; it could be a pre-existing issue in the test that only surfaces now for some reason. I didn't find anything particularly interesting between Puppeteer 21.5.0 and 21.5.1, but apparently something changed to make it show up. |
I looked into this and could already reproduce this locally with master. I have made #17261 to check this further and it's indeed already failing on master, so it's not related to this PR. I'll check if I can find where this started failing because it must have been a very recent change given that the integration tests passed two days ago. |
I have bisected it and created #17262 to track the integration test problem which indeed turned out to be pre-existing issue. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, this should be fine to land as-is since the integrationtest
failure is unrelated; thank you!
No description provided.