-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Firefox] Fetch browser preferences/options together with the viewer preferences (bug 1862192) #17208
[Firefox] Fetch browser preferences/options together with the viewer preferences (bug 1862192) #17208
Conversation
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/76d8f7709b27198/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/2680b36b442b27b/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/76d8f7709b27198/output.txt Total script time: 25.04 mins
Image differences available at: http://54.241.84.105:8877/76d8f7709b27198/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/2680b36b442b27b/output.txt Total script time: 35.57 mins
Image differences available at: http://54.193.163.58:8877/2680b36b442b27b/reftest-analyzer.html#web=eq.log |
…preferences (bug 1862192) Currently we *synchronously* fetch a number of browser preferences/options, from the platform code, during the viewer respectively PDF document initialization paths. This seems unnecessary, and we can re-factor the code to instead include the relevant data when fetching the regular viewer preferences.
be51c86
to
eebc230
Compare
Given that this branch is only necessary in development mode and *during* building, but is never actually used in the final viewer-bundles, we can utilize the pre-processor to ignore this code.
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/91fb2e3107de413/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/91fb2e3107de413/output.txt Total script time: 1.52 mins Published |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you.
Currently we synchronously fetch a number of browser preferences/options, from the platform code, during the viewer respectively PDF document initialization paths.
This seems unnecessary, and we can re-factor the code to instead include the relevant data when fetching the regular viewer preferences.