-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add workflow to lint Fluent en-US files #17186
Conversation
96c1e37
to
f1e68bc
Compare
a273a69
to
9586b79
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me, with two more suggestions; thank you!
- Looking at the existing workflows they're all marked as readonly, so can the same be done for the new one? See e.g.
pdf.js/.github/workflows/ci.yml
Lines 3 to 4 in fbfacf8
permissions: contents: read - With the Fluent migration all string-ids now start with
pdfjs-
, could we configure the linter to enforce that?
9586b79
to
f701d07
Compare
That is not an option currently. The reason is that this linter is typically used in projects with multiple files, so we never implemented this type of check. I'll think about it though ;-) FIxed also the workflow extension from yaml to yml for consistency with existing workflows. |
f701d07
to
c6dd4d6
Compare
c6dd4d6
to
487816b
Compare
I swear I'm usually not this messy in PRs, but that's what happens if I try to multitask 🤦🏼 Filenames should all match now. |
@flodolo thank you for doing this: it was on my todo list but tbh not on my high priority one. |
This should prevent surprises when you port changes to mozilla-central