Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add workflow to lint Fluent en-US files #17186

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

flodolo
Copy link
Contributor

@flodolo flodolo commented Oct 26, 2023

This should prevent surprises when you port changes to mozilla-central

.github/workflows/reference_linter.yaml Outdated Show resolved Hide resolved
.github/workflows/reference_linter.yaml Outdated Show resolved Hide resolved
.github/linter_config.yml Outdated Show resolved Hide resolved
.github/workflows/reference_linter.yaml Outdated Show resolved Hide resolved
@Snuffleupagus Snuffleupagus linked an issue Oct 26, 2023 that may be closed by this pull request
@Snuffleupagus Snuffleupagus added the l10n Localization label Oct 26, 2023
@flodolo flodolo force-pushed the fluent_linter branch 2 times, most recently from a273a69 to 9586b79 Compare October 26, 2023 15:06
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with two more suggestions; thank you!

  • Looking at the existing workflows they're all marked as readonly, so can the same be done for the new one? See e.g.
    permissions:
    contents: read
  • With the Fluent migration all string-ids now start with pdfjs-, could we configure the linter to enforce that?

@flodolo
Copy link
Contributor Author

flodolo commented Oct 26, 2023

With the Fluent migration all string-ids now start with pdfjs-, could we configure the linter to enforce that?

That is not an option currently. The reason is that this linter is typically used in projects with multiple files, so we never implemented this type of check. I'll think about it though ;-)

FIxed also the workflow extension from yaml to yml for consistency with existing workflows.

@flodolo
Copy link
Contributor Author

flodolo commented Oct 26, 2023

I swear I'm usually not this messy in PRs, but that's what happens if I try to multitask 🤦🏼

Filenames should all match now.

@Snuffleupagus Snuffleupagus merged commit 3478112 into mozilla:master Oct 26, 2023
4 checks passed
@calixteman
Copy link
Contributor

@flodolo thank you for doing this: it was on my todo list but tbh not on my high priority one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n Localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a l10n linter
3 participants