Fix WidgetAnnotationElement._getKeyModifier to account for Linux
#17185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently the `WidgetAnnotationElement._getKeyModifier` method will always be falsy on Linux, which seems like a simple oversight. Looking at all the other `FeatureTest.platform` accesses we only handle the `isMac`-case specially, and it seems reasonable to do the same thing here. The reason that this hasn't led to any bug reports is most likely that the `modifier`-property seems completely unused in the scripting-implementation. Finally, with these changes we can (slightly) simplify the `FeatureTest.platform` implementation.
|
/botio xfatest |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/f76ebca54c17011/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/59090b6756bf3cc/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/f76ebca54c17011/output.txt Total script time: 10.55 mins
Image differences available at: http://54.241.84.105:8877/f76ebca54c17011/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/59090b6756bf3cc/output.txt Total script time: 19.93 mins
Image differences available at: http://54.193.163.58:8877/59090b6756bf3cc/reftest-analyzer.html#web=eq.log |
timvandermeij
approved these changes
Oct 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently the
WidgetAnnotationElement._getKeyModifiermethod will always be falsy on Linux, which seems like a simple oversight. Looking at all the otherFeatureTest.platformaccesses we only handle theisMac-case specially, and it seems reasonable to do the same thing here.The reason that this hasn't led to any bug reports is most likely that the
modifier-property seems completely unused in the scripting-implementation.Finally, with these changes we can (slightly) simplify the
FeatureTest.platformimplementation.