Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle appending consistently in the xfaLayer regardless of rendering intent (PR 17177 follow-up) #17184

Merged
merged 1 commit into from
Oct 28, 2023
Merged

Handle appending consistently in the xfaLayer regardless of rendering intent (PR 17177 follow-up) #17184

merged 1 commit into from
Oct 28, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

After PR #17177 the interface of XfaLayerBuilder is now inconsistent, since whether or not we directly append the xfaLayer to the DOM now depends on the rendering intent.

@Snuffleupagus
Handle appending consistently in the xfaLayer regardless of rendering…
097f214 
… intent (PR 17177 follow-up)

After PR 17177 the interface of `XfaLayerBuilder` is now inconsistent, since whether or not we directly append the xfaLayer to the DOM now depends on the rendering intent.
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/e9981da1372d157/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/e9981da1372d157/output.txt

Total script time: 1.48 mins

Published

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/55a2e58432e897f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/41997b1364937e8/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/55a2e58432e897f/output.txt

Total script time: 5.51 mins

  • Integration Tests: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/41997b1364937e8/output.txt

Total script time: 17.96 mins

  • Integration Tests: Passed

timvandermeij
timvandermeij approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@timvandermeij timvandermeij left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, but I'd like Calixte to also sign off on this given that he did reviewed the original patch. Thank you!

calixteman
calixteman approved these changes Oct 28, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit 80612f3 into mozilla:master Oct 28, 2023
3 checks passed
@Snuffleupagus Snuffleupagus deleted the xfaLayer-append-print branch October 28, 2023 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

@timvandermeij timvandermeij timvandermeij approved these changes

Assignees
No one assigned
Labels
form-xfa printing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Snuffleupagus @moz-tools-bot @timvandermeij @calixteman