[Editor] Remove almost all the waitForTimeout from the freetext integration tests #17036

calixteman · 2023-09-26T13:24:10Z

No description provided.

test/integration/test_utils.js

test/integration/freetext_editor_spec.js

Snuffleupagus

Please run the integration-tests a couple of times to ensure that there's no new intermittent failures.

r=me, with a few more questions; thank you!

test/integration/test_utils.js

calixteman · 2023-09-27T13:20:07Z

/botio integrationtest

moz-tools-bot · 2023-09-27T13:20:09Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/bf13c734f4d223e/output.txt

moz-tools-bot · 2023-09-27T13:20:09Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/9e34d913a6a09b7/output.txt

moz-tools-bot · 2023-09-27T13:25:47Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/bf13c734f4d223e/output.txt

Total script time: 5.62 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-27T13:41:42Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/9e34d913a6a09b7/output.txt

Total script time: 21.53 mins

Integration Tests: FAILED

calixteman · 2023-09-27T14:41:20Z

/botio integrationtest

moz-tools-bot · 2023-09-27T14:41:22Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/0f2b28153ed0126/output.txt

moz-tools-bot · 2023-09-27T14:41:23Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/692362d4cd8e267/output.txt

moz-tools-bot · 2023-09-27T14:46:52Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/0f2b28153ed0126/output.txt

Total script time: 5.47 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-27T15:02:08Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/692362d4cd8e267/output.txt

Total script time: 20.74 mins

Integration Tests: FAILED

calixteman · 2023-09-27T16:15:28Z

/botio integrationtest

moz-tools-bot · 2023-09-27T16:15:30Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/10bfc661a82dd13/output.txt

moz-tools-bot · 2023-09-27T16:15:30Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/dd6a2d1ce01abdc/output.txt

moz-tools-bot · 2023-09-27T16:20:58Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/10bfc661a82dd13/output.txt

Total script time: 5.45 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-27T16:34:55Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/dd6a2d1ce01abdc/output.txt

Total script time: 19.40 mins

Integration Tests: FAILED

calixteman · 2023-09-27T17:09:00Z

/botio integrationtest

moz-tools-bot · 2023-09-27T17:09:05Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c9478e430e1db2f/output.txt

moz-tools-bot · 2023-09-27T17:09:05Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b3a994103b691b1/output.txt

moz-tools-bot · 2023-09-27T17:14:41Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/b3a994103b691b1/output.txt

Total script time: 5.59 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-27T17:28:38Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/c9478e430e1db2f/output.txt

Total script time: 19.54 mins

Integration Tests: FAILED

moz-tools-bot · 2023-09-27T17:53:22Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/675f86f6b339580/output.txt

moz-tools-bot · 2023-09-27T17:54:52Z

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/9b4de3b5794399b/output.txt

Total script time: 23.73 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-27T17:58:51Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/d76fd93e521c594/output.txt

Total script time: 5.48 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-27T18:16:11Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/675f86f6b339580/output.txt

Total script time: 21.33 mins

Integration Tests: FAILED

calixteman · 2023-09-27T18:29:39Z

@Snuffleupagus, are you still ok with the patch ?

Snuffleupagus · 2023-09-27T19:12:54Z

are you still ok with the patch ?

First of all, there's now been a fair number of changes since I last looked and the earliest that I'll be able to re-review is tomorrow.
Secondly, with this no longer being a test only patch but it now also making changes to "regular" code this will probably require another level of scrutiny. Any chance that this could be split-up a bit, at least into multiple commits, to aid reviewing?

Snuffleupagus · 2023-09-29T07:40:26Z

/botio integrationtest

moz-tools-bot · 2023-09-29T07:40:28Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/85c0fc96e533d15/output.txt

moz-tools-bot · 2023-09-29T07:40:28Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/afc7d2c6e9a7915/output.txt

moz-tools-bot · 2023-09-29T07:46:19Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/85c0fc96e533d15/output.txt

Total script time: 5.83 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-29T07:58:57Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/afc7d2c6e9a7915/output.txt

Total script time: 18.47 mins

Integration Tests: FAILED

Snuffleupagus

r=me, thank you!

test/integration/test_utils.js

test/integration/freetext_editor_spec.js

…ration tests

calixteman · 2023-09-29T09:15:21Z

/botio integrationtest

moz-tools-bot · 2023-09-29T09:15:23Z

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1ac5833ba8ce25c/output.txt

moz-tools-bot · 2023-09-29T09:15:23Z

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/65bb878da065347/output.txt

moz-tools-bot · 2023-09-29T09:21:16Z

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/1ac5833ba8ce25c/output.txt

Total script time: 5.86 mins

Integration Tests: Passed

moz-tools-bot · 2023-09-29T09:34:58Z

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/65bb878da065347/output.txt

Total script time: 19.57 mins

Integration Tests: FAILED

calixteman added the editor label Sep 26, 2023

calixteman requested a review from Snuffleupagus September 26, 2023 13:24

Snuffleupagus reviewed Sep 27, 2023

View reviewed changes

test/integration/test_utils.js Outdated Show resolved Hide resolved

test/integration/test_utils.js Outdated Show resolved Hide resolved

test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved

calixteman force-pushed the fix_test_freetext branch from 6145191 to 50aec48 Compare September 27, 2023 11:51

Snuffleupagus approved these changes Sep 27, 2023

View reviewed changes

test/integration/test_utils.js Outdated Show resolved Hide resolved

test/integration/test_utils.js Outdated Show resolved Hide resolved

test/integration/test_utils.js Outdated Show resolved Hide resolved

calixteman force-pushed the fix_test_freetext branch from 50aec48 to eca0279 Compare September 27, 2023 13:19

calixteman force-pushed the fix_test_freetext branch from eca0279 to eabbeaf Compare September 27, 2023 14:40

calixteman force-pushed the fix_test_freetext branch from eabbeaf to 02f8ace Compare September 27, 2023 16:15

calixteman force-pushed the fix_test_freetext branch from 02f8ace to f19b48e Compare September 27, 2023 17:08

calixteman force-pushed the fix_test_freetext branch 3 times, most recently from 6af2bcf to adda2c0 Compare September 28, 2023 10:28

Snuffleupagus approved these changes Sep 29, 2023

View reviewed changes

test/integration/test_utils.js Outdated Show resolved Hide resolved

test/integration/freetext_editor_spec.js Outdated Show resolved Hide resolved

[Editor] Remove almost all the waitForTimeout from the freetext integ…

55e5af2

…ration tests

calixteman force-pushed the fix_test_freetext branch from adda2c0 to 55e5af2 Compare September 29, 2023 09:14

calixteman merged commit 46940a5 into mozilla:master Sep 29, 2023

calixteman deleted the fix_test_freetext branch September 29, 2023 09:41

Snuffleupagus added the test label Oct 6, 2023

Snuffleupagus linked an issue Oct 6, 2023 that may be closed by this pull request

Fix integration test "FreeText Editor FreeText rotation must check that the dimensions of a rotated annotations are correct after a font size change" #16968

Closed

calixteman mentioned this pull request Oct 7, 2023

Fix integration test "Interaction in doc_actions.pdf for page actions must execute PageOpen and PageClose actions" #16928

Closed

[Editor] Remove almost all the waitForTimeout from the freetext integration tests #17036

[Editor] Remove almost all the waitForTimeout from the freetext integration tests #17036

Conversation

calixteman commented Sep 26, 2023

Snuffleupagus left a comment

Choose a reason for hiding this comment

calixteman commented Sep 27, 2023

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Failed

calixteman commented Sep 27, 2023

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Failed

calixteman commented Sep 27, 2023

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Failed

calixteman commented Sep 27, 2023

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Failed

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Success

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Linux m4)

Success

moz-tools-bot commented Sep 27, 2023

From: Bot.io (Windows)

Failed

calixteman commented Sep 27, 2023

Snuffleupagus commented Sep 27, 2023

Snuffleupagus commented Sep 29, 2023

moz-tools-bot commented Sep 29, 2023

From: Bot.io (Linux m4)

Received

moz-tools-bot commented Sep 29, 2023

From: Bot.io (Windows)

Received

moz-tools-bot commented Sep 29, 2023