-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the round
CSS function in the setLayerDimensions
helper function
#16794
Conversation
This has now been enabled unconditionally in Firefox, see https://bugzilla.mozilla.org/show_bug.cgi?id=1814589 For the `page`-containers in the viewer, this patch should restore the behaviour prior to PR 15770; see e.g. https://github.com/mozilla/pdf.js/pull/15770/files#diff-c48e3561004f5db8f11d5ebab2fd661591222ba911cb4173fbced15f026bac6bL182-L183 Note that these changes this will lead to a tiny bit of movement in some `text` and `annotations` reference tests. Please find additional information at https://developer.mozilla.org/en-US/docs/Web/CSS/round
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/3e8c4acb6ead175/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1615a1c26b368bd/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1615a1c26b368bd/output.txt Total script time: 26.79 mins
Image differences available at: http://54.241.84.105:8877/1615a1c26b368bd/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/3e8c4acb6ead175/output.txt Total script time: 36.73 mins
Image differences available at: http://54.193.163.58:8877/3e8c4acb6ead175/reftest-analyzer.html#web=eq.log |
Looks good; thanks! /botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/c1434dd50bde801/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/4e1ec4f5b913356/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/c1434dd50bde801/output.txt Total script time: 21.84 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/4e1ec4f5b913356/output.txt Total script time: 25.15 mins
|
[Editor] Fix the dimensions of the annotation editor layer (follow-up of #16794)
This has now been enabled unconditionally in Firefox, see https://bugzilla.mozilla.org/show_bug.cgi?id=1814589
For the
page
-containers in the viewer, this patch should restore the behaviour prior to PR #15770; see e.g. https://github.com/mozilla/pdf.js/pull/15770/files#diff-c48e3561004f5db8f11d5ebab2fd661591222ba911cb4173fbced15f026bac6bL182-L183Note that these changes this will lead to a tiny bit of movement in some
text
andannotations
reference tests.Please find additional information at https://developer.mozilla.org/en-US/docs/Web/CSS/round