Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move the transfers computation into the AnnotationStorage class #16620

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Move the transfers computation into the AnnotationStorage class #16620

merged 1 commit into from
Jun 30, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

Rather than having to manually determine the potential transfers at various spots in the API, we can let the AnnotationStorage.serializable getter include this.
To further simplify things, we can also let the serializable getter compute and include the hash-string as well.

@Snuffleupagus Snuffleupagus force-pushed the AnnotationStorage-transfers branch 3 times, most recently from e7362a0 to 196c71e Compare June 29, 2023 07:17
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@Snuffleupagus Snuffleupagus force-pushed the AnnotationStorage-transfers branch from 196c71e to afb57e3 Compare June 29, 2023 08:41
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@Snuffleupagus Snuffleupagus force-pushed the AnnotationStorage-transfers branch from afb57e3 to defc71a Compare June 29, 2023 09:36
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@Snuffleupagus Snuffleupagus force-pushed the AnnotationStorage-transfers branch from defc71a to 982313d Compare June 29, 2023 09:58
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@Snuffleupagus Snuffleupagus requested a review from calixteman June 29, 2023 10:38
@Snuffleupagus Snuffleupagus force-pushed the AnnotationStorage-transfers branch from 982313d to 9c5e297 Compare June 29, 2023 12:42
@Snuffleupagus Snuffleupagus requested a review from calixteman June 29, 2023 13:26
@Snuffleupagus
Move the transfers computation into the AnnotationStorage class
39113ba 
Rather than having to *manually* determine the potential `transfers` at various spots in the API, we can let the `AnnotationStorage.serializable` getter include this.
To further simplify things, we can also let the `serializable` getter compute and include the `hash`-string as well.
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@Snuffleupagus Snuffleupagus force-pushed the AnnotationStorage-transfers branch from 9c5e297 to 39113ba Compare June 29, 2023 17:52
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@mozilla mozilla deleted a comment from moz-tools-bot Jun 29, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/158a30c44496009/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/e6d3b8c94bb90c9/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/158a30c44496009/output.txt

Total script time: 25.63 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 14
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/158a30c44496009/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/e6d3b8c94bb90c9/output.txt

Total script time: 38.71 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 28
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/e6d3b8c94bb90c9/reftest-analyzer.html#web=eq.log

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/dfabce375821608/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/f51eb039ad182a0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/dfabce375821608/output.txt

Total script time: 4.32 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/f51eb039ad182a0/output.txt

Total script time: 16.90 mins

  • Integration Tests: FAILED

calixteman
calixteman approved these changes Jun 30, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus merged commit ffa9795 into mozilla:master Jun 30, 2023
@Snuffleupagus Snuffleupagus deleted the AnnotationStorage-transfers branch June 30, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Snuffleupagus @moz-tools-bot @calixteman