Improve lint-chromium to output actionable information #16607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Note: this is intentionally branched off an older version of the master branch that did not include #16605, to show the new effect in CI. The old result can be seen in https://github.com/mozilla/pdf.js/actions/runs/5369999621/jobs/9760078018?pr=16601 from PR #16601. |
Actually, CI doesn't show the error because In any case, with the fix from #16605 the lint-chromium output wouldn't fail anyway. |
Rob--W
force-pushed
the
lint-chromium-actionable-warnings
branch
from
4e3b61c to
19084cf
Compare
Snuffleupagus
approved these changes
Jun 28, 2023
Before this commit, lint-chromium complained without an obvious course of action: > Warning: Pref objects doesn't have the same length. > Error: chromium/preferences_schema is not in sync With this commit, the error message is more actionable: > Warning: extensions/chromium/preferences_schema.json does not contain an entry for pref: enableFloatingToolbar > Error: chromium/preferences_schema is not in sync
Rob--W
force-pushed
the
lint-chromium-actionable-warnings
branch
from
19084cf to
8330390
Compare
timvandermeij
approved these changes
Jul 1, 2023
|
Good idea; thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this commit, lint-chromium complained without an obvious course of action:
With this commit, the error message is more actionable: