Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove a couple of unused constants from src/shared/util.js #16590

Merged
merged 1 commit into from
Jun 24, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

These constants were added "speculatively" in PR #10820, almost four years ago, but have never actually been used. We already have issue #10982 that tracks potentially extending support for the affected annotation-format, however until that happens I really don't think that we should keep shipping completely unused code in the PDF.js library.

For the MOZCENTRAL build-target, i.e. the Firefox PDF Viewer, this reduces the total bundle size by 1.1 kilo-byte.

@Snuffleupagus Snuffleupagus changed the title Remove a couple of unused constants from util src/shared/util.js Remove a couple of unused constants from src/shared/util.js Jun 23, 2023
These constants were added "speculatively" in PR 10820, almost four years ago, but have never actually been used. We already have issue 10982 that tracks *potentially* extending support for the affected annotation-format, however until that happens I really don't think that we should keep shipping completely unused code in the PDF.js library.

For the MOZCENTRAL build-target, i.e. the Firefox PDF Viewer, this reduces the total bundle size by 1.1 kilo-byte.
@Snuffleupagus Snuffleupagus force-pushed the rm-util-unused-const branch from 856d5df to b4b9419 Compare June 23, 2023 08:44
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/03010b2081725c4/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/bf1afb477c6c793/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/03010b2081725c4/output.txt

Total script time: 24.78 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 11
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/03010b2081725c4/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/bf1afb477c6c793/output.txt

Total script time: 38.01 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 27

Image differences available at: http://54.193.163.58:8877/bf1afb477c6c793/reftest-analyzer.html#web=eq.log

@Snuffleupagus Snuffleupagus requested a review from calixteman June 24, 2023 08:21
@timvandermeij timvandermeij merged commit 1ea502a into mozilla:master Jun 24, 2023
@timvandermeij
Copy link
Contributor

I agree; they can easily be put back once that functionality is implemented. Thanks!

@Snuffleupagus Snuffleupagus deleted the rm-util-unused-const branch June 25, 2023 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants