[api-minor] Re-factor the PDFScriptingManager class to use private fields/methods
#16569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Snuffleupagus
commented
Jun 20, 2023
Snuffleupagus
commented
- Change (most) fields/methods into private ones, since that's now supported.
- Tweak the constructor-parameters, and simplify the sandbox initialization w.r.t. the viewer components.
- Remove some unused function/method parameters.
- Slightly simplify the "updatefromsandbox"-handler by using local variables and inverting some conditions.
Rather than sprinkling pre-processor statements throughout the viewer-code, simply "disable" the relevant `PDFViewer` setters instead. Also, given that the GeckoView-specific viewer doesn't have a sidebar we don't actually need to explicitly ignore a `pageMode` during loading.
…fields/methods - Change (most) fields/methods into private ones, since that's now supported. - Tweak the constructor-parameters, and simplify the sandbox initialization w.r.t. the viewer components. - Remove some unused function/method parameters. - Slightly simplify the "updatefromsandbox"-handler by using local variables and inverting some conditions.
Snuffleupagus
force-pushed
the
PDFScriptingManager-private
branch
from
45ab503 to
547b827
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/836b216e493bad8/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d93f46236eefa95/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/836b216e493bad8/output.txt Total script time: 4.82 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d93f46236eefa95/output.txt Total script time: 16.45 mins
|
timvandermeij
approved these changes
Jun 24, 2023
|
Nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.