Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a container for Signature with their own canvas #16554

Merged
merged 1 commit into from
Jun 15, 2023
Merged

Add a container for Signature with their own canvas #16554

merged 1 commit into from
Jun 15, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from Snuffleupagus June 15, 2023 11:01
@calixteman calixteman linked an issue Jun 15, 2023 that may be closed by this pull request
Digital signature from Okular is not shown #16553
Closed
Snuffleupagus
Snuffleupagus approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

src/display/annotation_layer.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/763a8fd356b557c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/7212049c58a1a91/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/763a8fd356b557c/output.txt

Total script time: 40.24 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 52
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/763a8fd356b557c/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/7212049c58a1a91/output.txt

Total script time: 49.81 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 42
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/7212049c58a1a91/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a7aa337e038313f/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/42827acd79dccee/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/a7aa337e038313f/output.txt

Total script time: 25.00 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 12

Image differences available at: http://54.241.84.105:8877/a7aa337e038313f/reftest-analyzer.html#web=eq.log

@calixteman calixteman requested a review from Snuffleupagus June 15, 2023 13:16
@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/42827acd79dccee/output.txt

Total script time: 38.39 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  errors: 1
  different ref/snapshot: 22

Image differences available at: http://54.193.163.58:8877/42827acd79dccee/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus approved these changes Jun 15, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that code-changes in the latest patch, please update the commit message to mention that this is now for "signature widget".

@calixteman calixteman changed the title Add a container for widget with their own canvas Add a container for Signature with their own canvas Jun 15, 2023
@calixteman calixteman merged commit 9f60686 into mozilla:master Jun 15, 2023
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/9d4ddd857799cba/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ff0ef0655d89f55/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ff0ef0655d89f55/output.txt

Total script time: 4.70 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: FAILED (no refs found)

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/9d4ddd857799cba/output.txt

Total script time: 20.77 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman
Copy link
Contributor Author

/botio-windows makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/61ef3c395531491/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/61ef3c395531491/output.txt

Total script time: 25.61 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@calixteman calixteman deleted the issue16553 branch June 15, 2023 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
annotations
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Digital signature from Okular is not shown
3 participants
@calixteman @moz-tools-bot @Snuffleupagus