Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Add the possibility to update an existing annotation with some new properties when saving or printing #16523

Merged
merged 1 commit into from
Jun 9, 2023
Merged

[Editor] Add the possibility to update an existing annotation with some new properties when saving or printing #16523

merged 1 commit into from
Jun 9, 2023

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman requested a review from Snuffleupagus June 5, 2023 13:08
@marco-c marco-c linked an issue Jun 5, 2023 that may be closed by this pull request
Support editing already existing annotations #15403
Closed
@calixteman calixteman force-pushed the restore_save branch 3 times, most recently from 23f6d0e to ff265f0 Compare June 6, 2023 16:40
Snuffleupagus
Snuffleupagus requested changes Jun 6, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a few comments based on a quick look.

src/core/annotation.js Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
src/core/document.js Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
src/display/annotation_storage.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the restore_save branch 4 times, most recently from 8f1d832 to c06c8e7 Compare June 8, 2023 16:43
Snuffleupagus
Snuffleupagus reviewed Jun 8, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also run all tests and I'll try to do a final review during the weekend.

test/test_manifest.json Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
src/core/document.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the restore_save branch 2 times, most recently from 771f9ec to 245c3a2 Compare June 8, 2023 20:20
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/ee5e4a6cbf03230/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/614892f43d8ff3d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/614892f43d8ff3d/output.txt

Total script time: 24.81 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 8
  different first/second rendering: 2

Image differences available at: http://54.241.84.105:8877/614892f43d8ff3d/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/ee5e4a6cbf03230/output.txt

Total script time: 36.14 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 34

Image differences available at: http://54.193.163.58:8877/ee5e4a6cbf03230/reftest-analyzer.html#web=eq.log

Snuffleupagus
Snuffleupagus reviewed Jun 9, 2023
View reviewed changes
src/core/document.js Outdated Show resolved Hide resolved
@calixteman calixteman requested a review from Snuffleupagus June 9, 2023 12:34
Snuffleupagus
Snuffleupagus reviewed Jun 9, 2023
View reviewed changes
src/core/primitives.js Outdated Show resolved Hide resolved
src/core/primitives.js Outdated Show resolved Hide resolved
Snuffleupagus
Snuffleupagus approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, thank you!

src/core/document.js Outdated Show resolved Hide resolved
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/b55844abb486fc7/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/99f74741a6aee34/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/b55844abb486fc7/output.txt

Total script time: 24.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 12
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/b55844abb486fc7/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/99f74741a6aee34/output.txt

Total script time: 36.81 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 29

Image differences available at: http://54.193.163.58:8877/99f74741a6aee34/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit b8447eb into mozilla:master Jun 9, 2023
@calixteman
Copy link
Contributor Author

/botio makeref

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/c7c840191cb491d/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/32250a77341382c/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c7c840191cb491d/output.txt

Total script time: 20.44 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Success

Full output at http://54.193.163.58:8877/32250a77341382c/output.txt

Total script time: 24.52 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support editing already existing annotations
3 participants
@calixteman @moz-tools-bot @Snuffleupagus