Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Guess font size and color from the AS of FreeText annotations #16522

Merged

Conversation

calixteman
Copy link
Contributor

No description provided.

src/core/annotation.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the restore_get_freetext_info_from_as branch from 44b6db5 to 2a7c615 Compare June 5, 2023 12:03
src/core/annotation.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the restore_get_freetext_info_from_as branch from 2a7c615 to b2487f4 Compare June 5, 2023 13:50
test/unit/default_appearance_spec.js Outdated Show resolved Hide resolved
test/unit/default_appearance_spec.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the restore_get_freetext_info_from_as branch 2 times, most recently from 671181b to eac61bb Compare June 5, 2023 14:56
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with a couple more comments and passing tests; thank you!

src/core/default_appearance.js Outdated Show resolved Hide resolved
src/core/default_appearance.js Outdated Show resolved Hide resolved
@calixteman calixteman force-pushed the restore_get_freetext_info_from_as branch from eac61bb to ba8c996 Compare June 5, 2023 15:15
@calixteman
Copy link
Contributor Author

/botio test

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/8566ba81793b99b/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/39a518760c40da6/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/8566ba81793b99b/output.txt

Total script time: 24.19 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 16
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/8566ba81793b99b/reftest-analyzer.html#web=eq.log

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/39a518760c40da6/output.txt

Total script time: 36.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 28
  different first/second rendering: 2

Image differences available at: http://54.193.163.58:8877/39a518760c40da6/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 9cd84aa into mozilla:master Jun 5, 2023
@calixteman calixteman deleted the restore_get_freetext_info_from_as branch June 5, 2023 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants