Enable the import/no-cycle ESLint plugin rule

[Snuffleupagus]

Having cyclical imports is obviously not a good idea, and this ESLint plugin rule can help detect those; please see https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-cycle.md

[Snuffleupagus]

@calixteman Do you have any ideas/opinions on how to best break the dependency cycles in the xfa/-code, without having to move loads of code?
See https://github.com/mozilla/pdf.js/actions/runs/5155612716/jobs/9285509966?pr=16515#step:6:54

[calixteman]

We could move the symbols $... used in som.js into a separate file which can be then imported by both files.
Then we can add a flag in both classes XFAObject and XFAObjectArray (e.g. isXfaObject and isXFAObjectArray) to avoid the use of instanceof in som.js.
And to fix the XmlObject issue, since createNodes is not really related to the som stuff we could move it in XFAObject as a method and then in som.js replace the use of createNodes(root, path) by root.createNodes(path).

[Snuffleupagus]

/botio xfatest

[moz-tools-bot]

From: Bot.io (Windows)

---

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/962eb8037796cb0/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Received

Command cmd_xfatest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7088a1a2e2ed2dc/output.txt

[moz-tools-bot]

From: Bot.io (Linux m4)

---

Failed

Full output at http://54.241.84.105:8877/7088a1a2e2ed2dc/output.txt

Total script time: 9.23 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.241.84.105:8877/7088a1a2e2ed2dc/reftest-analyzer.html#web=eq.log

[moz-tools-bot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/962eb8037796cb0/output.txt

Total script time: 18.06 mins

• Font tests: Passed
• Unit tests: Passed
• Integration Tests: FAILED
• Regression tests: FAILED

  different ref/snapshot: 2

Image differences available at: http://54.193.163.58:8877/962eb8037796cb0/reftest-analyzer.html#web=eq.log

[timvandermeij]

Looks good to me, with a rebase. Thanks!