Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix incorrect USERACTIVATION_CALLBACKID import (15618 follow-up) #16511

Merged
merged 1 commit into from
Jun 2, 2023
Merged

Fix incorrect USERACTIVATION_CALLBACKID import (15618 follow-up) #16511

merged 1 commit into from
Jun 2, 2023

Conversation

Snuffleupagus
Copy link
Collaborator

This constant is currently imported from the wrong file, where it doesn't exist; see PR #15618.

@Snuffleupagus
Fix incorrect USERACTIVATION_CALLBACKID import (15618 follow-up)
2db0eff 
This constant is currently imported from the wrong file, where it doesn't exist; see PR 15618.
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/37616c14eda70ff/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6fa074296c9fd89/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/37616c14eda70ff/output.txt

Total script time: 4.48 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/30afa738ba4bdf0/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/30afa738ba4bdf0/output.txt

Total script time: 4.05 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/6fa074296c9fd89/output.txt

Total script time: 17.48 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/4841b450786e784/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/745eea0ead0b3ab/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/4841b450786e784/output.txt

Total script time: 4.00 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

/botio-linux integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/1d3f632f9abf0f1/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/1d3f632f9abf0f1/output.txt

Total script time: 4.01 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/745eea0ead0b3ab/output.txt

Total script time: 15.49 mins

  • Integration Tests: FAILED

@Snuffleupagus
Copy link
Collaborator Author

This seems to lead to more intermittent failures, so this might not be enough on its own unfortunately :-(

@Snuffleupagus Snuffleupagus deleted the pr-15618-followup branch June 2, 2023 08:38
@calixteman
Copy link
Contributor

For me this patch is good.
Why did you say that it led to more intermittents ?

@Snuffleupagus
Copy link
Collaborator Author

There's a lot of failures in the must check if printing is triggered when the document is open test, which I don't believe used to happen before?

But if you're OK with this, then we can certainly just land this!

@calixteman
Copy link
Contributor

The only consequence of the bug is to not reset the userAction flag:
https://github.com/mozilla/pdf.js/blob/master/src/scripting_api/app.js#L92

so if there's a print more than 5s after a user activity then the print wouldn't have been ignored.

@Snuffleupagus Snuffleupagus restored the pr-15618-followup branch June 2, 2023 10:34
@Snuffleupagus Snuffleupagus reopened this Jun 2, 2023
@Snuffleupagus
Copy link
Collaborator Author

/botio integrationtest

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/a16672089054071/output.txt

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7b0bb38aae35703/output.txt

@calixteman
Copy link
Contributor

Locally, autoprint.pdf is working as expected.

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Linux m4)

Failed

Full output at http://54.241.84.105:8877/7b0bb38aae35703/output.txt

Total script time: 3.95 mins

  • Integration Tests: FAILED

@moz-tools-bot
Copy link
Collaborator

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/a16672089054071/output.txt

Total script time: 15.59 mins

  • Integration Tests: FAILED

@calixteman
Copy link
Contributor

calixteman commented Jun 2, 2023 •
edited
Loading

Locally autoprint.pdf is working well on Windows and on a Ubuntu through WSL but I'll test on a real linux device just to be sure.
Do you have any idea why the linter didn't catch this obvious error ?

@calixteman
Copy link
Contributor

WFM on Fedora.

calixteman
calixteman approved these changes Jun 2, 2023
View reviewed changes
Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you.

@Snuffleupagus Snuffleupagus linked an issue Jun 2, 2023 that may be closed by this pull request
Incorrect USERACTIVATION_CALLBACKID import in src/scripting_api/event.js #16512
Closed
@Snuffleupagus Snuffleupagus merged commit a43b124 into mozilla:master Jun 2, 2023
@Snuffleupagus Snuffleupagus deleted the pr-15618-followup branch June 2, 2023 11:10
@Snuffleupagus
Copy link
Collaborator Author

Do you have any idea why the linter didn't catch this obvious error ?

Because we didn't enable the necessary ESLint-plugin rule to catch such cases, patch coming soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@calixteman calixteman calixteman approved these changes

Assignees
No one assigned
Labels
form-js
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Incorrect USERACTIVATION_CALLBACKID import in src/scripting_api/event.js
3 participants
@Snuffleupagus @moz-tools-bot @calixteman