Improve handling of JPEG images with non-standard /Decode-entries (issue 16395) #16396
Conversation
…sue 16395) The /Decode-implementation in the our JPEG decoder, i.e. `src/core/jpg.js`, seems to only handle *inverting* of images properly. To support arbitrary /Decode-entries correctly we'll always use the `PDFImage.decodeBuffer` method, even for "simple" JPEG images, which should be fine since non-default /Decode-entries aren't a very common occurrence. *Please note:* This patch will lead to a little bit of movement in some existing test-cases, however it should be virtually imperceivable to the naked eye.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1a251f7e7748fd5/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/b004d61439b3e09/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/1a251f7e7748fd5/output.txt Total script time: 27.23 mins
Image differences available at: http://54.241.84.105:8877/1a251f7e7748fd5/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/b004d61439b3e09/output.txt Total script time: 33.43 mins
Image differences available at: http://54.193.163.58:8877/b004d61439b3e09/reftest-analyzer.html#web=eq.log |
|
/botio makeref |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/8cce60430daaae1/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/0dc582b68b3edd8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/0dc582b68b3edd8/output.txt Total script time: 22.86 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/8cce60430daaae1/output.txt Total script time: 24.11 mins
|
The /Decode-implementation in the our JPEG decoder, i.e.
src/core/jpg.js, seems to only handle inverting of images properly. To support arbitrary /Decode-entries correctly we'll always use thePDFImage.decodeBuffermethod, even for "simple" JPEG images, which should be fine since non-default /Decode-entries aren't a very common occurrence.Please note: This patch will lead to a little bit of movement in some existing test-cases, however it should be virtually imperceivable to the naked eye.