Simplify the thumbnail styling in the viewer #16374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
thumbnail-styles
branch
from
bb1b67b to
ee0659e
Compare
Snuffleupagus
force-pushed
the
thumbnail-styles
branch
from
ee0659e to
fc9853a
Compare
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/4c0f4472be25d3e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/4c0f4472be25d3e/output.txt Total script time: 1.25 mins Published |
calixteman
reviewed
May 4, 2023
This patch tries to simplify, and improve, the thumbnail styling: - For rendered thumbnails there's one less DOM-element per thumbnail, which can't hurt in longer documents. - Use CSS-variables to set the dimensions of all relevant DOM-elements at once. - Simplify the visual styling of the thumbnails, e.g. remove the border since the viewer no longer has visible borders around pages, since the relevant CSS-rules are quite old code. These changes also, at least in my opinion, makes the relevant CSS-rules much easier to understand and work with. - Make it easier to work on e.g. [bug 1690428](https://bugzilla.mozilla.org/show_bug.cgi?id=1690428) without affecting the other sidebarViews.
…13357 follow-up)
Snuffleupagus
force-pushed
the
thumbnail-styles
branch
from
fc9853a to
74c615b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch tries to simplify, and improve, the thumbnail styling:
These changes also, at least in my opinion, makes the relevant CSS-rules much easier to understand and work with.