Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use the deprecated CustomEvent.initCustomEvent method anymore #16336

Merged
merged 1 commit into from
Apr 23, 2023

Conversation

timvandermeij
Copy link
Contributor

In PR #16295 one occurrence of this was changed, but a few more remained in the codebase. This commit fixes the other occurrences so that we don't use the deprecated way of creating custom events anywhere anymore.

According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/initCustomEvent, using the CustomEvent.initCustomEvent method is deprecated and the CustomEvent constructor should be used instead.

Extends d9bf571.

@timvandermeij
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5243e4a414601ed/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5243e4a414601ed/output.txt

Total script time: 1.31 mins

Published

@timvandermeij
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5508a39f9408a98/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @timvandermeij received. Current queue size: 0

Live output at: http://54.193.163.58:8877/fa3e040e958e626/output.txt

web/event_utils.js Outdated Show resolved Hide resolved
web/firefoxcom.js Outdated Show resolved Hide resolved
@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/5508a39f9408a98/output.txt

Total script time: 4.10 mins

  • Integration Tests: FAILED

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/fa3e040e958e626/output.txt

Total script time: 14.51 mins

  • Integration Tests: FAILED

In PR mozilla#16295 one occurrence of this was changed, but a few more remained
in the codebase. This commit fixes the other occurrences so that we
don't use the deprecated way of creating custom events anywhere anymore.

According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/initCustomEvent,
using the `CustomEvent.initCustomEvent` method is deprecated and the
`CustomEvent` constructor should be used instead.

Extends d9bf571.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally this patch, once applied to the Firefox-repository, passed all relevant tests when running ./mach test toolkit/components/pdfjs/.

r=me, thank you!

@timvandermeij timvandermeij merged commit 28f96d2 into mozilla:master Apr 23, 2023
@timvandermeij timvandermeij deleted the custom-event branch April 23, 2023 14:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants