-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't use the deprecated CustomEvent.initCustomEvent
method anymore
#16336
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5243e4a414601ed/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/5243e4a414601ed/output.txt Total script time: 1.31 mins Published |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.241.84.105:8877/5508a39f9408a98/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @timvandermeij received. Current queue size: 0 Live output at: http://54.193.163.58:8877/fa3e040e958e626/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/5508a39f9408a98/output.txt Total script time: 4.10 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/fa3e040e958e626/output.txt Total script time: 14.51 mins
|
In PR mozilla#16295 one occurrence of this was changed, but a few more remained in the codebase. This commit fixes the other occurrences so that we don't use the deprecated way of creating custom events anywhere anymore. According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/initCustomEvent, using the `CustomEvent.initCustomEvent` method is deprecated and the `CustomEvent` constructor should be used instead. Extends d9bf571.
a33b8e5
to
870b942
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Locally this patch, once applied to the Firefox-repository, passed all relevant tests when running ./mach test toolkit/components/pdfjs/
.
r=me, thank you!
In PR #16295 one occurrence of this was changed, but a few more remained in the codebase. This commit fixes the other occurrences so that we don't use the deprecated way of creating custom events anywhere anymore.
According to MDN, see https://developer.mozilla.org/en-US/docs/Web/API/CustomEvent/initCustomEvent, using the
CustomEvent.initCustomEvent
method is deprecated and theCustomEvent
constructor should be used instead.Extends d9bf571.