Update eslint-plugin-mozilla to avoid having to force-install packages (issue 15429)
#16327
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ges (issue 15429) The latest version of `eslint-plugin-mozilla` removed the Prettier dependency, see https://bugzilla.mozilla.org/show_bug.cgi?id=1677562, which means that we no longer need to use `npm install --force` in the PDF.js library.
timvandermeij
added a commit
to timvandermeij/pdf.js
that referenced
this pull request
Apr 23, 2023
In PR mozilla#16327 the `eslint-plugin-mozilla` package was updated so we no longer have to force-install packages, and the force-install flags for `npm install` were removed. However, the CI job was missing from this commit, which we fix here. In general force-installing packages shouldn't be necessary unless there are problems with dependencies, which we would like to know about, so especially in the CI job it seems like a good idea to not force-install packages to catch upcoming defects early on. Extends 19526d2.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The latest version of
eslint-plugin-mozillaremoved the Prettier dependency, see https://bugzilla.mozilla.org/show_bug.cgi?id=1677562, which means that we no longer need to usenpm install --forcein the PDF.js library.