Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation] A combo can have a value other than one in the options #16035

Merged
merged 1 commit into from
Feb 9, 2023

Conversation

calixteman
Copy link
Contributor

When printing the pdf in #12233 in Acrobat, we can see that the combo for country
is empty: it's because the V entry doesn't have to be one of the options.

@calixteman
Copy link
Contributor Author

calixteman commented Feb 9, 2023

That said, the html element we chose for combo is wrong: it should be more something like an input with type set to list but we'll lose the arrow (which is, I think, useful to indicate that there are some possible choices) but this can be fixed thanks to css.

When printing the pdf in mozilla#12233 in Acrobat, we can see that the combo for country
is empty: it's because the V entry doesn't have to be one of the options.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/4f342361e9bc672/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Received

Command cmd_test from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/d11fb47ee4b7831/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/d11fb47ee4b7831/output.txt

Total script time: 26.12 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 14
  different first/second rendering: 1

Image differences available at: http://54.241.84.105:8877/d11fb47ee4b7831/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/4f342361e9bc672/output.txt

Total script time: 33.94 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 26
  different first/second rendering: 1

Image differences available at: http://54.193.163.58:8877/4f342361e9bc672/reftest-analyzer.html#web=eq.log

@calixteman
Copy link
Contributor Author

The two failures for ...issue12233... are expected because this patch has been written especially for this reason.

@calixteman calixteman merged commit 0fca6e1 into mozilla:master Feb 9, 2023
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/a59fb0696a1be4e/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 1

Live output at: http://54.193.163.58:8877/6c1b6640a30249c/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/a59fb0696a1be4e/output.txt

Total script time: 21.95 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 9, 2023

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/6c1b6640a30249c/output.txt

Total script time: 23.83 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants