Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Make the annotation editor layer invisible when disabled and empty #15970

Merged
merged 1 commit into from
Feb 1, 2023

Conversation

calixteman
Copy link
Contributor

It'll help to avoid to consider them when the browser is restyling.

src/display/editor/annotation_editor_layer.js Outdated Show resolved Hide resolved
src/display/editor/annotation_editor_layer.js Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.js Outdated Show resolved Hide resolved
web/annotation_editor_layer_builder.js Outdated Show resolved Hide resolved
… empty

It'll help to avoid to consider them when the browser is restyling.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me, with passing tests; thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2023

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/fb98463eecc78ad/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2023

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/469876c708e49f3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2023

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/fb98463eecc78ad/output.txt

Total script time: 4.25 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

pdfjsbot commented Feb 1, 2023

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/469876c708e49f3/output.txt

Total script time: 11.37 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 1bdee0b into mozilla:master Feb 1, 2023
@calixteman calixteman deleted the editor_invisible branch February 1, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants