Decouple the loadingBar background-color from the rest of the viewer
#15874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With upcoming background changes elsewhere in the viewer, this should be helpful in separating the styling of the loadingBar. These changes also means that both the "regular" and the "indeterminate" loadingBar now uses the same `background-color` value. Also, shortens the related CSS variables a little bit since that can't hurt.
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b79e4e0851cc9b6/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b79e4e0851cc9b6/output.txt Total script time: 1.26 mins Published |
Given that there's no loadingBar element present in the GeckoView-viewer, we shouldn't need CSS variables for it.
timvandermeij
approved these changes
Dec 31, 2022
|
Thanks! |
|
@timvandermeij Do you have time to make a new release, since it's probably time for that now? |
|
Ha, I was just about to push the shiny green button ;-) PDF.js version 3.2.146 is now available: https://github.com/mozilla/pdf.js/releases/tag/v3.2.146. I'll push the bump commit soon. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With upcoming background changes elsewhere in the viewer, this should be helpful in separating the styling of the loadingBar. These changes also means that both the "regular" and the "indeterminate" loadingBar now uses the same
background-colorvalue.Also, shortens the related CSS variables a little bit since that can't hurt.