[Regression] Ensure that documents with varying page sizes are initialized correctly (PR 15812 follow-up) #15872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lized correctly (PR 15812 follow-up) The rotation-caching added in PR 15812 completely breaks initialization of PDF documents with varying page sizes, causing all pages to wrongly get the same size; see e.g. `sizes.pdf` from the test-suite. To fix that without having to e.g. add a new parameter, which feels error prone, this patch changes the `PDFPageView.#setDimensions` method to completely ignore the rotation-caching until the `setPdfPage`-method has been called.
Snuffleupagus
added
viewer
regression
release-blocker
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b2e16efe4dda8a8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/b2e16efe4dda8a8/output.txt Total script time: 1.26 mins Published |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rotation-caching added in PR #15812 completely breaks initialization of PDF documents with varying page sizes, causing all pages to wrongly get the same size; see e.g.
sizes.pdffrom the test-suite.To fix that without having to e.g. add a new parameter, which feels error prone, this patch changes the
PDFPageView.#setDimensionsmethod to completely ignore the rotation-caching until thesetPdfPage-method has been called.