-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove PDFPageProxy.getJSActions
caching, since it's unused, in the API
#15870
Remove PDFPageProxy.getJSActions
caching, since it's unused, in the API
#15870
Conversation
… API Note how, in the scripting initialization in the viewer, we only ever invoke `PDFPageProxy.getJSActions` *once* per page in order to improve overall performance; see https://github.com/mozilla/pdf.js/blob/a575aa13b9e4ce7e671be7794e7a7296406a3087/web/pdf_scripting_manager.js#L372-L375 Hence it really shouldn't be necessary to cache its result in the API, especially when that is done *manually* rather than using something like `shadow`.
/botio unittest |
From: Bot.io (Linux m4)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.241.84.105:8877/fd1f2526044eef3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_unittest from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/3844ec615dd5891/output.txt |
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.241.84.105:8877/1620f2619dd56e3/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 2 Live output at: http://54.193.163.58:8877/820f0a51c39ddd1/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/fd1f2526044eef3/output.txt Total script time: 2.31 mins
|
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1620f2619dd56e3/output.txt Total script time: 4.27 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/3844ec615dd5891/output.txt Total script time: 11.36 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/820f0a51c39ddd1/output.txt Total script time: 12.19 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Note how, in the scripting initialization in the viewer, we only ever invoke
PDFPageProxy.getJSActions
once per page in order to improve overall performance; seepdf.js/web/pdf_scripting_manager.js
Lines 372 to 375 in a575aa1
Hence it really shouldn't be necessary to cache its result in the API, especially when that is done manually rather than using something like
shadow
.