Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Avoid to scroll when an annotation is commited (fixes issue #15744) #15849

Merged
merged 1 commit into from
Dec 17, 2022
Merged

[Editor] Avoid to scroll when an annotation is commited (fixes issue #15744) #15849

merged 1 commit into from
Dec 17, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman linked an issue Dec 17, 2022 that may be closed by this pull request
Returns the position of the previous ink text when scrolling to the next page #15744
Closed
Snuffleupagus
Snuffleupagus approved these changes Dec 17, 2022
View reviewed changes
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to MDN this is supported in all browsers that we care about: https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/focus#browser_compatibility

That's easier than I imagined it would be, thank you!

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/867d90f77638a6c/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/140c382c393b0dd/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/867d90f77638a6c/output.txt

Total script time: 4.26 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)

Failed

Full output at http://54.193.163.58:8877/140c382c393b0dd/output.txt

Total script time: 12.42 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit dd96ee1 into mozilla:master Dec 17, 2022
@calixteman calixteman deleted the 15744 branch December 17, 2022 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Snuffleupagus approved these changes

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Returns the position of the previous ink text when scrolling to the next page
3 participants
@calixteman @pdfjsbot @Snuffleupagus