Avoid to compute the client rect of the viewer #15830
Conversation
|
@Snuffleupagus if I overlooked something with the removal of the height stuff, please tell me but in looking at the devtools my impress was that the height is finally always 100% of its parent. |
calixteman
force-pushed
the
dont_compute_rect
branch
2 times, most recently
from
8760bf6 to
7c8b777
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/43d4cd2cef608f5/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/43d4cd2cef608f5/output.txt Total script time: 1.25 mins Published |
calixteman
force-pushed
the
dont_compute_rect
branch
from
7c8b777 to
649bb47
Compare
The container position and dimensions should be almost constant, hence it's pretty useless to query them on each rescale. Finally it avoids to trigger some reflows.
calixteman
force-pushed
the
dont_compute_rect
branch
from
649bb47 to
c550953
Compare
|
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/db0aee8e5f8426f/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/14cad6a8fe66da2/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/14cad6a8fe66da2/output.txt Total script time: 4.71 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/db0aee8e5f8426f/output.txt Total script time: 11.35 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b8edcd2896e324c/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/6da2b540c78e5c2/output.txt |
|
The failures are likely due to #15845. |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b8edcd2896e324c/output.txt Total script time: 4.81 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/6da2b540c78e5c2/output.txt Total script time: 5.18 mins
|
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/a63d427ea5c3015/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 1 Live output at: http://54.193.163.58:8877/98117f53a2a3429/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/a63d427ea5c3015/output.txt Total script time: 4.22 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/98117f53a2a3429/output.txt Total script time: 9.83 mins
|
The container position and dimensions should be almost constant, hence
it's pretty useless to query them on each rescale.
Finally it avoids to trigger some reflows.