[api-minor] Add a new PageViewport-getter to access the original, un-scaled, viewport dimensions
#15797
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Snuffleupagus
force-pushed
the
PageViewport-rawDims
branch
from
888a0f9 to
723b819
Compare
Snuffleupagus
force-pushed
the
PageViewport-rawDims
branch
from
723b819 to
edadff7
Compare
…n-scaled, viewport dimensions While reviewing recent patches, I couldn't help but noticing that we now have a lot of call-sites that manually access the `PageViewport.viewBox`-property. Rather than repeating that verbatim all over the code-base, this patch adds a lazily computed and cached getter for this data instead.
Snuffleupagus
force-pushed
the
PageViewport-rawDims
branch
from
edadff7 to
cafdc48
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/b3e97ded73f5799/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/cc952d22ccaa372/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/b3e97ded73f5799/output.txt Total script time: 25.49 mins
Image differences available at: http://54.241.84.105:8877/b3e97ded73f5799/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/cc952d22ccaa372/output.txt Total script time: 32.46 mins
Image differences available at: http://54.193.163.58:8877/cc952d22ccaa372/reftest-analyzer.html#web=eq.log |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While reviewing recent patches, I couldn't help but noticing that we now have a lot of call-sites that manually access the
PageViewport.viewBox-property.Rather than repeating that verbatim all over the code-base, this patch adds a lazily computed and cached getter for this data instead.