A few small viewer-related fixes #15788
Conversation
|
/botio integrationtest |
This change was made in PR 5552, however I cannot tell why we needed to disable searching in PresentationMode. Furthermore, with the changes in PR 13908 which effectively moved where this code is invoked, searching has now (accidentally) been working in PresentationMode in e.g. the Firefox PDF Viewer for well over a year. So, let's just enable searching unconditionally in PresentationMode to simplify the code.
Snuffleupagus
force-pushed
the
web-small-fixes
branch
from
9289cb7 to
556f4e8
Compare
…API functionality The `PDFPageProxy._pageIndex` property is a "private" one that shouldn't be accessed, since it could theoretically break tomorrow if we re-factor the relevant API code. Also, try to clean-up and improve consistency in a couple of JSDoc comments.
Snuffleupagus
force-pushed
the
web-small-fixes
branch
from
556f4e8 to
d7d21f0
Compare
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/1bee30b9889a200/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/1bee30b9889a200/output.txt Total script time: 1.26 mins Published |
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/35a6d95245a407e/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/ed8dafd2443f330/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/35a6d95245a407e/output.txt Total script time: 4.25 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/ed8dafd2443f330/output.txt Total script time: 11.67 mins
|
Stop trying to disable searching in PresentationMode
This change was made in PR Creates/refactors PDFPageView class #5552, however I cannot tell why we needed to disable searching in PresentationMode. Furthermore, with the changes in PR [api-minor] XFA - Support text search in XFA documents. #13908 which effectively moved where this code is invoked, searching has now (accidentally) been working in PresentationMode in e.g. the Firefox PDF Viewer for well over a year.
So, let's just enable searching unconditionally in PresentationMode to simplify the code.
Change
AnnotationEditorLayerBuilder.renderto not access "private" API functionalityThe
PDFPageProxy._pageIndexproperty is a "private" one that shouldn't be accessed, since it could theoretically break tomorrow if we re-factor the relevant API code.Also, try to clean-up and improve consistency in a couple of JSDoc comments.