Don't re-create the structTreeLayer on zooming and rotation
#15778
Conversation
Also change the "private" methods into properly private ones.
|
/botio integrationtest |
Snuffleupagus
force-pushed
the
keep-structTree
branch
from
816528c to
f9f884d
Compare
Compared to the recent PR 15722 for the `textLayer` this one should be a (comparatively) much a smaller win overall, since most documents don't have any structTree-data and the required parsing should be cheaper. However, it seems to me that it cannot hurt to improve this nonetheless. Note that by moving the `structTreeLayer` initialization we remove the need for the "textlayerrendered" event listener, which thus simplifies the code a little bit. Also, removes the API-caching of the structTree-data since this was basically done to offset the lack of caching in the viewer.
Snuffleupagus
force-pushed
the
keep-structTree
branch
from
f9f884d to
da0e6bc
Compare
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/40ee55dbfcd6042/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5cf7f4c7faebd68/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/40ee55dbfcd6042/output.txt Total script time: 25.57 mins
Image differences available at: http://54.241.84.105:8877/40ee55dbfcd6042/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5cf7f4c7faebd68/output.txt Total script time: 33.96 mins
Image differences available at: http://54.193.163.58:8877/5cf7f4c7faebd68/reftest-analyzer.html#web=eq.log |
|
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3deb117db922470/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/3deb117db922470/output.txt Total script time: 1.27 mins Published |
Compared to the recent PR #15722 for the
textLayerthis one should be a (comparatively) much a smaller win overall, since most documents don't have any structTree-data and the required parsing should be cheaper. However, it seems to me that it cannot hurt to improve this nonetheless.Note that by moving the
structTreeLayerinitialization we remove the need for the "textlayerrendered" event listener, which thus simplifies the code a little bit.Also, removes the API-caching of the structTree-data since this was basically done to offset the lack of caching in the viewer.