Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Editor] Change the cursor icons #15633

Merged
merged 1 commit into from
Oct 29, 2022
Merged

[Editor] Change the cursor icons #15633

merged 1 commit into from
Oct 29, 2022

Conversation

calixteman
Copy link
Contributor

No description provided.

@calixteman calixteman marked this pull request as draft October 27, 2022 09:50
@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/27d20077db06af8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/27d20077db06af8/output.txt

Total script time: 1.23 mins

Published

@Snuffleupagus
Copy link
Collaborator

Given that the new ink-icon looks like a definite improvement, and should also be the "most" affected one here, do we perhaps want to land that one right away so that it makes the next release (this weekend)?

@calixteman calixteman marked this pull request as ready for review October 28, 2022 16:39
@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7ae5ef0d7d25f39/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/7ae5ef0d7d25f39/output.txt

Total script time: 1.24 mins

Published

@Snuffleupagus
Copy link
Collaborator

Unfortunately the cursor-editorFreeText.svg icon looks quite "fuzzy" on a non-HiDPI screen.

@calixteman
Copy link
Contributor Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Received

Command cmd_preview from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/c81fceef0f99290/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)

Success

Full output at http://54.241.84.105:8877/c81fceef0f99290/output.txt

Total script time: 1.27 mins

Published

@Snuffleupagus Snuffleupagus merged commit 5b46400 into mozilla:master Oct 29, 2022
@Snuffleupagus Snuffleupagus linked an issue Oct 29, 2022 that may be closed by this pull request
Annotation editor cursors have poor visibility over black text/images #15611
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Snuffleupagus Snuffleupagus Awaiting requested review from Snuffleupagus

Assignees
No one assigned
Labels
editor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Annotation editor cursors have poor visibility over black text/images
3 participants
@calixteman @pdfjsbot @Snuffleupagus