Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Annotation] Replace use of id by data-element-id to have the correct id (bug 1796544) #15598

Merged
merged 1 commit into from
Oct 19, 2022

Conversation

calixteman
Copy link
Contributor

Closes #15597.

@Snuffleupagus
Copy link
Collaborator

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/7ff64a7d58501c2/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/7ff64a7d58501c2/output.txt

Total script time: 1.39 mins

Published

@Snuffleupagus
Copy link
Collaborator

Given that this looks like a regression, probably from PR #15057, would it be feasible to add an integration-test to ensure that this doesn't accidentally break again?
This particular code-path isn't taken for most forms, so we probably don't have good test-coverage as-is.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/115b1c13d9e6a71/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/142ee5320c6e5a8/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/142ee5320c6e5a8/output.txt

Total script time: 1.04 mins

  • Integration Tests: Passed

@@ -95,6 +95,31 @@ describe("Checkbox annotation", () => {
);
});
});

fdescribe("issue15597.pdf", () => {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, oblivion (it's to run only this test, iirc f==focus)

@pdfjsbot
Copy link

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/115b1c13d9e6a71/output.txt

Total script time: 5.90 mins

  • Integration Tests: Passed

@Snuffleupagus
Copy link
Collaborator

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/cfd5d24045bbf51/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/5b9956c1297202e/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/cfd5d24045bbf51/output.txt

Total script time: 3.70 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/5b9956c1297202e/output.txt

Total script time: 9.38 mins

  • Integration Tests: FAILED

@Snuffleupagus Snuffleupagus merged commit f3949ba into mozilla:master Oct 19, 2022
@marco-c marco-c changed the title [Annotation] Replace use of id by data-element-id to have the correct id [Annotation] Replace use of id by data-element-id to have the correct id (bug 1796544) Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot check a checkbox
3 participants