-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Annotation] Replace use of id by data-element-id to have the correct id (bug 1796544) #15598
Conversation
/botio-linux preview |
From: Bot.io (Linux m4)ReceivedCommand cmd_preview from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/7ff64a7d58501c2/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/7ff64a7d58501c2/output.txt Total script time: 1.39 mins Published |
Given that this looks like a regression, probably from PR #15057, would it be feasible to add an integration-test to ensure that this doesn't accidentally break again? |
/botio integrationtest |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.193.163.58:8877/115b1c13d9e6a71/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/142ee5320c6e5a8/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/142ee5320c6e5a8/output.txt Total script time: 1.04 mins
|
test/integration/annotation_spec.js
Outdated
@@ -95,6 +95,31 @@ describe("Checkbox annotation", () => { | |||
); | |||
}); | |||
}); | |||
|
|||
fdescribe("issue15597.pdf", () => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, oblivion (it's to run only this test, iirc f==focus)
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/115b1c13d9e6a71/output.txt Total script time: 5.90 mins
|
/botio integrationtest |
From: Bot.io (Linux m4)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/cfd5d24045bbf51/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_integrationtest from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/5b9956c1297202e/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/cfd5d24045bbf51/output.txt Total script time: 3.70 mins
|
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/5b9956c1297202e/output.txt Total script time: 9.38 mins
|
Closes #15597.