[Editor] Make FreeText annotations visible for screen readers when in editing mode (bug 1793419)

[calixteman]

• When we're editing some annotations, keeping the role="text-box" make them visible as editable and VoiceOver (Mac) is able to read the contents when they're focused;
• Add an attribute "aria-activedescendant" in order to make the content discoverable by NVDA on Windows.

[Snuffleupagus]

Given my complete lack of a11y knowledge I cannot really review this as such, however the actual code changes seem OK as far as I can tell.

[calixteman]

I tested on Mac 12.6 with VoiceOver and on Windows 11 with NVDA, in both cases I think it works as expected (I'm not an a11y expert either).

[calixteman]

Anyway, I pinged @MReschenberg about this patch.

[MReschenberg]

Hihi, I've tested this locally -- looks good to me :)
@calixteman I'm testing on 12.5.1 and on my machine (for some reason) the VO visual cursor doesn't accurately bound the annotation. Instead of tightly wrapping the text editor area, the VO visual cursor is off to the side. VO correctly reads/routes actions to the editor object though, and the editor text seems to be "in flow" with its location in the PDF.

Are you seeing anything similar on your end?
I don't think this is a result of this patch (I can repro in Nightly) but thought I'd flag it.

[calixteman]

@MReschenberg, could you attach a screenshot ? I used VO for the 1st time today, so I'm not sure to know what it is correct or not.

[MReschenberg]

yep here ya go, the black rectangle box is the VO visual cursor. Even though it doesn't match up with where the annotation area actually is, that's what it says is focused.

[calixteman]

I'm not able to reproduce in neither nightly nor release (and even not in a local build with my patch), but my macOS version is 12.6. Anyway, as you said it's unrelated to this patch, so let's land it!

[calixteman]

/botio integrationtest

[pdfjsbot]

From: Bot.io (Linux m4)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/147311d408e1c9c/output.txt

[pdfjsbot]

From: Bot.io (Windows)

---

Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/6507d2f089b4a97/output.txt

[pdfjsbot]

From: Bot.io (Linux m4)

---

Success

Full output at http://54.241.84.105:8877/147311d408e1c9c/output.txt

Total script time: 3.82 mins

• Integration Tests: Passed

[pdfjsbot]

From: Bot.io (Windows)

---

Failed

Full output at http://54.193.163.58:8877/6507d2f089b4a97/output.txt

Total script time: 11.98 mins

• Integration Tests: FAILED

[calixteman]

Windows integration tests are green locally: I really need to fix them on the bot.