Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[XFA] Add some padding inline in selects #15549

Merged
merged 1 commit into from
Oct 7, 2022

Conversation

calixteman
Copy link
Contributor

Because of https://bugzilla.mozilla.org/show_bug.cgi?id=1582545, the padding-inline is by default 0. 0 is not really enough because of the outline, so just set it to 2px (it was 4px before the patch) in order to have something visually correct.

Because of https://bugzilla.mozilla.org/show_bug.cgi?id=1582545, the padding-inline is by default 0.
0 is not really enough because of the outline, so just set it to 2px (it was 4px before the patch)
in order to have something visually correct.
Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That seems reasonable, thanks!

@calixteman
Copy link
Contributor Author

/botio xfatest

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Windows)


Received

Command cmd_xfatest from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/e44b69c9c649bb3/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Linux m4)


Received

Command cmd_xfatest from @calixteman received. Current queue size: 1

Live output at: http://54.241.84.105:8877/09fcc3de88e41f0/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/09fcc3de88e41f0/output.txt

Total script time: 10.46 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 36

Image differences available at: http://54.241.84.105:8877/09fcc3de88e41f0/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/e44b69c9c649bb3/output.txt

Total script time: 13.60 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: FAILED
  different ref/snapshot: 18

Image differences available at: http://54.193.163.58:8877/e44b69c9c649bb3/reftest-analyzer.html#web=eq.log

@calixteman calixteman merged commit 3dc9b42 into mozilla:master Oct 7, 2022
@calixteman
Copy link
Contributor Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/25647b134210f4d/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @calixteman received. Current queue size: 2

Live output at: http://54.193.163.58:8877/cd7ac7469c8e838/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/25647b134210f4d/output.txt

Total script time: 22.03 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Oct 7, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/cd7ac7469c8e838/output.txt

Total script time: 22.91 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants