-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[XFA] Add some padding inline in selects #15549
Conversation
Because of https://bugzilla.mozilla.org/show_bug.cgi?id=1582545, the padding-inline is by default 0. 0 is not really enough because of the outline, so just set it to 2px (it was 4px before the patch) in order to have something visually correct.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That seems reasonable, thanks!
/botio xfatest |
From: Bot.io (Windows)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 2 Live output at: http://54.193.163.58:8877/e44b69c9c649bb3/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_xfatest from @calixteman received. Current queue size: 1 Live output at: http://54.241.84.105:8877/09fcc3de88e41f0/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/09fcc3de88e41f0/output.txt Total script time: 10.46 mins
Image differences available at: http://54.241.84.105:8877/09fcc3de88e41f0/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/e44b69c9c649bb3/output.txt Total script time: 13.60 mins
Image differences available at: http://54.193.163.58:8877/e44b69c9c649bb3/reftest-analyzer.html#web=eq.log |
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 0 Live output at: http://54.241.84.105:8877/25647b134210f4d/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @calixteman received. Current queue size: 2 Live output at: http://54.193.163.58:8877/cd7ac7469c8e838/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/25647b134210f4d/output.txt Total script time: 22.03 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/cd7ac7469c8e838/output.txt Total script time: 22.91 mins
|
Because of https://bugzilla.mozilla.org/show_bug.cgi?id=1582545, the padding-inline is by default 0. 0 is not really enough because of the outline, so just set it to 2px (it was 4px before the patch) in order to have something visually correct.