[api-minor] Make isOffscreenCanvasSupported configurable via the API (issue 14952)
#15542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/82b4ad898307e48/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/50ced6d48abe9a6/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/82b4ad898307e48/output.txt Total script time: 25.64 mins
Image differences available at: http://54.241.84.105:8877/82b4ad898307e48/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/50ced6d48abe9a6/output.txt Total script time: 29.56 mins
Image differences available at: http://54.193.163.58:8877/50ced6d48abe9a6/reftest-analyzer.html#web=eq.log |
…I (issue 14952) This patch first of all makes `isOffscreenCanvasSupported` configurable, defaulting to `true` in browsers and `false` in Node.js environments, with a new `getDocument` parameter. While you normally want to use this, in order to improve performance, it should still be possible for users to control it (similar to e.g. `isEvalSupported`). The specific problem, as reported in issue 14952, is that the SVG back-end doesn't support the new ImageMask data-format that's introduced in PR 14754. In particular: - When the SVG back-end is used in Node.js environments, this patch will "just work" without the user needing to make any code changes. - If the SVG back-end is used in browsers, this patch will require that `isOffscreenCanvasSupported: false` is added to the `getDocument`-call.
Snuffleupagus
force-pushed
the
issue-14952
branch
from
78d8b32 to
1ea4c4b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch first of all makes
isOffscreenCanvasSupportedconfigurable, defaulting totruein browsers andfalsein Node.js environments, with a newgetDocumentparameter. While you normally want to use this, in order to improve performance, it should still be possible for users to control it (similar to e.g.isEvalSupported).The specific problem, as reported in issue #14952, is that the SVG back-end doesn't support the new ImageMask data-format that's introduced in PR #14754. In particular:
isOffscreenCanvasSupported: falseis added to thegetDocument-call.