Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set a border-radius when hovering annotationLayer-inputs (PR 15438 follow-up) #15491

Merged

Conversation

Snuffleupagus
Copy link
Collaborator

The changes in PR #15438 added a border-radius when input-elements are focused, however there's no radius when the same elements are hovered. Having the radius change, and not just the border-color, when input goes from hovered to focused feels a bit inconsistent (at least to me).

…follow-up)

The changes in PR 15438 added a `border-radius` when input-elements are focused, however there's no radius when the same elements are hovered. Having the radius change, and not just the `border-color`, when input goes from hovered to focused feels a bit inconsistent (at least to me).
@Snuffleupagus
Copy link
Collaborator Author

/botio-linux preview

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_preview from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/793c6daa0675ea6/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/793c6daa0675ea6/output.txt

Total script time: 2.13 mins

Published

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and I agree: it's better like this.

@Snuffleupagus Snuffleupagus merged commit 784ec39 into mozilla:master Sep 22, 2022
@Snuffleupagus Snuffleupagus deleted the annotationLayer-input-hover-border branch September 22, 2022 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants