Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #selectEditors typo in the AnnotationEditorUIManager.unselectAll method #15474

Merged
merged 1 commit into from
Sep 20, 2022
Merged

Conversation

nmtigor
Copy link
Contributor

@nmtigor nmtigor commented Sep 20, 2022

…method

@Snuffleupagus
Copy link
Collaborator

As mentioned in #15469 (comment), this seems like the sort of change that'd benefit from a test-case.

@calixteman
Copy link
Contributor

It's a typo... I added the check just in order to avoid to trigger an event:

this.#dispatchUpdateStates({

And it should already been covered by either integration tests in this repo and/or in mochitests in m-c.

@Snuffleupagus
Copy link
Collaborator

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/61987e7a1f8ab7a/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/34945227859867b/output.txt

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/61987e7a1f8ab7a/output.txt

Total script time: 5.02 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/34945227859867b/output.txt

Total script time: 11.42 mins

  • Integration Tests: FAILED

Copy link
Collaborator

@Snuffleupagus Snuffleupagus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@Snuffleupagus Snuffleupagus changed the title Fix #selectEditors typo in the AnnotationEditorUIManager.unselectAll … Fix #selectEditors typo in the AnnotationEditorUIManager.unselectAll method Sep 20, 2022
@Snuffleupagus Snuffleupagus merged commit 8dd2b48 into mozilla:master Sep 20, 2022
@nmtigor nmtigor deleted the fix_bugs_10 branch September 20, 2022 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants