Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bugs #15463

Closed
wants to merge 1 commit into from
Closed

Fix bugs #15463

wants to merge 1 commit into from

Conversation

nmtigor
Copy link
Contributor

@nmtigor nmtigor commented Sep 20, 2022 •
edited
Loading

@Snuffleupagus
Copy link
Collaborator

Snuffleupagus commented Sep 20, 2022 •
edited
Loading

Sorry, but we unfortunately cannot accept a PR like this.

Please note that all patches need to contain proper commit messages explaining what's being changed and importantly why, hence "Fix bugs" is really not sufficient in order to understand the changes. Also, if at all possible, all patches should ideally include tests.
Finally, please note that completely separate changes should usually be split into separate commits (or even separate PRs) to allow reviewing/testing without "mixing" different things.

@nmtigor nmtigor deleted the fix_bugs branch September 20, 2022 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmtigor @Snuffleupagus