Replace some unnecessary String.prototype.search usage
#15458
Conversation
Most of the `String.prototype.search` call-sites found throughout the code-base is actually not necessary, since we usually only want a *boolean*, and those can be replaced with `RegExp.prototype.test` instead.
|
/botio test |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/e8f0cb57b86d46a/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/a137ae2e7e86b94/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/e8f0cb57b86d46a/output.txt Total script time: 26.03 mins
Image differences available at: http://54.241.84.105:8877/e8f0cb57b86d46a/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/a137ae2e7e86b94/output.txt Total script time: 29.45 mins
Image differences available at: http://54.193.163.58:8877/a137ae2e7e86b94/reftest-analyzer.html#web=eq.log |
Unfortunately I can't find an existing plugin for this, since https://github.com/sindresorhus/eslint-plugin-unicorn/blob/main/docs/rules/prefer-regexp-test.md only covers other regular expression functions. |
Most of the
String.prototype.searchcall-sites found throughout the code-base is actually not necessary, since we usually only want a boolean, and those can be replaced withRegExp.prototype.testinstead.