Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't allow adjustToUnicode to extend a built-in /ToUnicode map (issue 15352) #15392

Merged
merged 1 commit into from
Sep 4, 2022

Conversation

Snuffleupagus
Copy link
Collaborator

Given that the change in PR #13393 was slightly speculative, given the lack of test-cases, let's just revert part of that to fix the referenced issue.
Based on a quick look at old issues and existing test-cases, it seems that most (if not all) PDF documents that benefit from using the font-data in this way lack any /ToUnicode maps which should mean that they're unaffected by these changes.

…sue 15352)

Given that the change in PR 13393 was slightly speculative, given the lack of test-cases, let's just revert part of that to fix the referenced issue.
Based on a quick look at old issues and existing test-cases, it seems that most (if not all) PDF documents that benefit from using the font-data in this way lack any /ToUnicode maps which should mean that they're unaffected by these changes.
@Snuffleupagus Snuffleupagus linked an issue Sep 3, 2022 that may be closed by this pull request
@Snuffleupagus
Copy link
Collaborator Author

/botio test

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2022

From: Bot.io (Windows)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.193.163.58:8877/d0515375172071a/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2022

From: Bot.io (Linux m4)


Received

Command cmd_test from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/3770bdf4bd680e1/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2022

From: Bot.io (Linux m4)


Failed

Full output at http://54.241.84.105:8877/3770bdf4bd680e1/output.txt

Total script time: 26.61 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: Passed
  • Regression tests: FAILED
  different ref/snapshot: 37

Image differences available at: http://54.241.84.105:8877/3770bdf4bd680e1/reftest-analyzer.html#web=eq.log

@pdfjsbot
Copy link

pdfjsbot commented Sep 3, 2022

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/d0515375172071a/output.txt

Total script time: 29.15 mins

  • Font tests: Passed
  • Unit tests: Passed
  • Integration Tests: FAILED
  • Regression tests: Passed

Copy link
Contributor

@calixteman calixteman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks reasonable and there are no regressions.

@Snuffleupagus Snuffleupagus merged commit 9578152 into mozilla:master Sep 4, 2022
@Snuffleupagus
Copy link
Collaborator Author

/botio makeref

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2022

From: Bot.io (Linux m4)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 0

Live output at: http://54.241.84.105:8877/2fd871ca9253314/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2022

From: Bot.io (Windows)


Received

Command cmd_makeref from @Snuffleupagus received. Current queue size: 1

Live output at: http://54.193.163.58:8877/0c53feee6dd54c9/output.txt

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2022

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/2fd871ca9253314/output.txt

Total script time: 22.10 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@pdfjsbot
Copy link

pdfjsbot commented Sep 4, 2022

From: Bot.io (Windows)


Success

Full output at http://54.193.163.58:8877/0c53feee6dd54c9/output.txt

Total script time: 22.16 mins

  • Lint: Passed
  • Make references: Passed
  • Check references: Passed

@Snuffleupagus Snuffleupagus deleted the issue-15352 branch September 4, 2022 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] The textlayer has some unexpected chars.
3 participants