-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't allow adjustToUnicode
to extend a built-in /ToUnicode map (issue 15352)
#15392
Conversation
…sue 15352) Given that the change in PR 13393 was slightly speculative, given the lack of test-cases, let's just revert part of that to fix the referenced issue. Based on a quick look at old issues and existing test-cases, it seems that most (if not all) PDF documents that benefit from using the font-data in this way lack any /ToUnicode maps which should mean that they're unaffected by these changes.
/botio test |
From: Bot.io (Windows)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.193.163.58:8877/d0515375172071a/output.txt |
From: Bot.io (Linux m4)ReceivedCommand cmd_test from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/3770bdf4bd680e1/output.txt |
From: Bot.io (Linux m4)FailedFull output at http://54.241.84.105:8877/3770bdf4bd680e1/output.txt Total script time: 26.61 mins
Image differences available at: http://54.241.84.105:8877/3770bdf4bd680e1/reftest-analyzer.html#web=eq.log |
From: Bot.io (Windows)FailedFull output at http://54.193.163.58:8877/d0515375172071a/output.txt Total script time: 29.15 mins
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks reasonable and there are no regressions.
/botio makeref |
From: Bot.io (Linux m4)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 0 Live output at: http://54.241.84.105:8877/2fd871ca9253314/output.txt |
From: Bot.io (Windows)ReceivedCommand cmd_makeref from @Snuffleupagus received. Current queue size: 1 Live output at: http://54.193.163.58:8877/0c53feee6dd54c9/output.txt |
From: Bot.io (Linux m4)SuccessFull output at http://54.241.84.105:8877/2fd871ca9253314/output.txt Total script time: 22.10 mins
|
From: Bot.io (Windows)SuccessFull output at http://54.193.163.58:8877/0c53feee6dd54c9/output.txt Total script time: 22.16 mins
|
Given that the change in PR #13393 was slightly speculative, given the lack of test-cases, let's just revert part of that to fix the referenced issue.
Based on a quick look at old issues and existing test-cases, it seems that most (if not all) PDF documents that benefit from using the font-data in this way lack any /ToUnicode maps which should mean that they're unaffected by these changes.