Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Editor] Avoid to update default params too early #15369

Merged
merged 1 commit into from
Aug 31, 2022

Conversation

calixteman
Copy link
Contributor

I got this exception in nightly:

Uncaught TypeError: can't access property Symbol.iterator, this[#editorTypes] is null
    updateParams resource://pdf.js/build/pdf.js:4393
    set annotationEditorParams resource://pdf.js/web/viewer.js:11521
    webViewerSwitchAnnotationEditorParams resource://pdf.js/web/viewer.js:3477
    dispatch resource://pdf.js/web/viewer.js:4133
    bindListeners resource://pdf.js/web/viewer.js:4496

I don't know how to reproduce the issue.

@calixteman
Copy link
Contributor Author

/botio integrationtest

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.241.84.105:8877/5341259e3a10da0/output.txt

@pdfjsbot
Copy link

From: Bot.io (Windows)


Received

Command cmd_integrationtest from @calixteman received. Current queue size: 0

Live output at: http://54.193.163.58:8877/c01e72764c2c7ec/output.txt

@Snuffleupagus
Copy link
Collaborator

I got this exception in nightly:
[...]
I don't know how to reproduce the issue.

I only managed to reproduce this by having a PDF document open when applying a Nightly-update, and could then see those Errors in the console when the browser had restarted after doing the update.
However I've not been able to reproduce this in any other way, e.g. by manually re-starting the browser, so hopefully this isn't a common problem. I'm also slightly confused as to how that problem even happens though!

@pdfjsbot
Copy link

From: Bot.io (Linux m4)


Success

Full output at http://54.241.84.105:8877/5341259e3a10da0/output.txt

Total script time: 5.03 mins

  • Integration Tests: Passed

@pdfjsbot
Copy link

From: Bot.io (Windows)


Failed

Full output at http://54.193.163.58:8877/c01e72764c2c7ec/output.txt

Total script time: 11.48 mins

  • Integration Tests: FAILED

@calixteman calixteman merged commit 54d3b64 into mozilla:master Aug 31, 2022
@calixteman calixteman deleted the update_params branch August 31, 2022 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants